Update lib dependencies and add some small fixes #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added to ensure we get an error returned on dial failure
rsafonseca
changed the title
Pull Request Test Coverage Report for Build 1449865424
💛 - Coveralls |
luizmiranda7
approved these changes
Sep 1, 2021
rsafonseca
changed the title
Comment on lines
+109
to
+110
| sd.etcdDialKeepAliveTime = sd.config.GetDuration("pitaya.cluster.sd.etcd.dialtimeout") | ||
| sd.etcdDialKeepAliveTimeout = sd.config.GetDuration("pitaya.cluster.sd.etcd.dialtimeout") |
There was a problem hiding this comment.
We should be using pitaya.cluster.sd.etcd.dialkeepalivetime and pitaya.cluster.sd.etcd.dialkeepalivetimeout here, like in config/config.go, right?
There was a problem hiding this comment.
yep, this is just adding to all locations this new configuration option, it's basically a built-in mechanism in etcd client to check if the connection is alive https://github.com/etcd-io/etcd/blob/7ea5ee8b5dcdceb5a26a5c1dfe7ca290000a007b/client/v3/config.go#L39
This isn't required for the fixes, it was just adding some extra configurability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.