[DONE] client SendRequest returns message id #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 216
💛 - Coveralls |
felipejfc
reviewed
Jun 25, 2018
client/client.go
Outdated
| @@ -374,8 +375,8 @@ func (c *Client) sendMsg(msgType message.Type, route string, data []byte) error | |||
| } | |||
|
|
|||
| if err != nil { | |||
| return err | |||
| return 0, err | |||
There was a problem hiding this comment.
I don't see why not return the id here instead of 0
There was a problem hiding this comment.
But if an error occurred what is the point on having the id? It should probably not be used anyway
rcmgleite
force-pushed
the
feature/pitaya-client-message-id
branch
from
d8882d0
to
4e4f74c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.