Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout improvements #310

Merged
merged 5 commits into from
May 19, 2023
Merged

Timeout improvements #310

merged 5 commits into from
May 19, 2023

Conversation

felipejfc
Copy link
Contributor

  • Remove redundant context.cancel
  • Improve error message for route timeouts, no more clients will see "nats: timeout" but a better error msg with metadata
  • Remove default request timeout unless passed by context (we already have a rpc timeout in place that's used by processRemoteMessage)

@coveralls
Copy link

coveralls commented May 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5029066667

  • 15 of 28 (53.57%) changed or added relevant lines in 6 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 62.104%
Changes Missing Coverage Covered Lines Changed/Added Lines %
util/util.go 0 3 0.0%
service/remote.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
service/remote.go 3 63.17%
Totals Coverage Status
Change from base Build 4931122122: 0.05%
Covered Lines: 4728
Relevant Lines: 7613
💛 - Coveralls

@felipejfc felipejfc merged commit dabd42a into main May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipejfc @coveralls