Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONE] Feature/struct validation pipeline #42

Merged
merged 1 commit into from
Aug 16, 2018

Conversation

rcmgleite
Copy link
Contributor

No description provided.

@rcmgleite rcmgleite force-pushed the feature/struct-validation-pipeline branch from 508fe19 to ccd7786 Compare August 16, 2018 19:54
@rcmgleite rcmgleite requested a review from andrehp August 16, 2018 19:54
@rcmgleite rcmgleite force-pushed the feature/struct-validation-pipeline branch from ccd7786 to 41d76c8 Compare August 16, 2018 21:40
@rcmgleite rcmgleite changed the title [WIP] Feature/struct validation pipeline [DONE] Feature/struct validation pipeline Aug 16, 2018
@rcmgleite rcmgleite force-pushed the feature/struct-validation-pipeline branch from 41d76c8 to 8957c9e Compare August 16, 2018 21:42
* - pitaya.defaultpipelines.structvalidation.enabled
- false
- bool
- Whether Pitaya should use the default struct validator for handler arguments
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Whether Pitaya should enable the default struct validator for handler arguments would sound better

@andrehp andrehp merged commit 26412ab into master Aug 16, 2018
@andrehp andrehp deleted the feature/struct-validation-pipeline branch August 16, 2018 21:43
@coveralls
Copy link

Pull Request Test Coverage Report for Build 424

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 75.405%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app.go 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
agent/agent.go 12 77.57%
Totals Coverage Status
Change from base Build 417: -0.2%
Covered Lines: 3722
Relevant Lines: 4936

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants