Push and kick fix ( Closes #51 ) #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the conflicts |
andrehp
suggested changes
Sep 17, 2018
kick_test.go
Outdated
|
|
||
| failedUids, err := SendKickToUsers([]string{table.uid1, table.uid2}, table.frontendType) | ||
| assert.Nil(t, failedUids) |
There was a problem hiding this comment.
Why did you split the test into two?
kick_test.go
Outdated
| assert.NoError(t, err) | ||
| assert.Nil(t, failedUids) |
There was a problem hiding this comment.
Pleas add a test for the error case as well
|
I believe the solution is good and lets the applications check which user ids failed, we just need to fix some things and then we are ready to go. |
gabrielerzinger
force-pushed
the
bugfix/kick
branch
from
a7e72ec
to
4d78010
Compare
Pull Request Test Coverage Report for Build 511
💛 - Coveralls |
andrehp
approved these changes
Sep 17, 2018
andrehp
changed the title
|
Good job, let's release this as v0.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request address to issue #51 with a possible solution.
It is a WIP because it still needs to be rebased with master and because it will break compatibility with projects that uses Pitaya, therefore, we need to version it before. Although, i've opened the PR so we can discuss if this solution is appropriate.