handshake compression + compressData viper config + adapt tests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 119
💛 - Coveralls |
andrehp
reviewed
Apr 19, 2018
agent/agent.go
Outdated
| if len(compressedData) < len(data) { | ||
| data = compressedData | ||
| } | ||
|
|
andrehp
reviewed
Apr 19, 2018
examples/demo/cluster/main.go
Outdated
| @@ -34,7 +34,7 @@ func configureBackend() { | |||
| } | |||
|
|
|||
| func configureFrontend(port int) { | |||
| ws := acceptor.NewWSAcceptor(fmt.Sprintf(":%d", port)) | |||
| ws := acceptor.NewTCPAcceptor(fmt.Sprintf(":%d", port)) | |||
There was a problem hiding this comment.
Shouldn't this still be WS?
traysh
force-pushed
the
feature/compression
branch
2 times, most recently
from
a8cab2e
to
228cee8
Compare
felipejfc
requested changes
Apr 23, 2018
There was a problem hiding this comment.
util/compression/compression.go
needs unit tests, see https://github.com/topfreegames/pitaya/blob/master/util/util_test.go#L169-L216
traysh
force-pushed
the
feature/compression
branch
2 times, most recently
from
98c3c13
to
b44e6d3
Compare
traysh
force-pushed
the
feature/compression
branch
from
b44e6d3
to
41843dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.