Listening to multiple queues #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermef
force-pushed
the
listenin-multiple-queues
branch
3 times, most recently
from
3bb5ae5
to
91427d1
Compare
cscatolini
approved these changes
Sep 25, 2017
| Expect(handler.run).To(BeTrue()) | ||
| }) | ||
| }) | ||
| // Describe("Handle Messages", func() { |
There was a problem hiding this comment.
why is this test commented?
| Expect(handler.run).To(BeTrue()) | ||
| }) | ||
| }) | ||
| // Describe("Handle Messages", func() { |
There was a problem hiding this comment.
why is this test also commented?
| l := t.Logger.WithFields(logrus.Fields{ | ||
| "method": "HandleToken", | ||
| "token": token, | ||
| }) | ||
| l.Debug("deleting token") | ||
| query := fmt.Sprintf("DELETE FROM %s WHERE token = ?0;", t.tableName) | ||
| query := fmt.Sprintf("DELETE FROM %s WHERE token = ?0;", game+"_"+platform) |
There was a problem hiding this comment.
I am not sure all games respect this rule =(
There was a problem hiding this comment.
omg, we need to be sure @guilhermef
guilhermef
force-pushed
the
listenin-multiple-queues
branch
from
91427d1
to
dc03844
Compare
guilhermef
force-pushed
the
listenin-multiple-queues
branch
from
dc03844
to
36bcdcf
Compare
felipejfc
reviewed
Sep 25, 2017
| l := t.Logger.WithFields(logrus.Fields{ | ||
| "method": "HandleToken", | ||
| "token": token, | ||
| }) | ||
| l.Debug("deleting token") | ||
| query := fmt.Sprintf("DELETE FROM %s WHERE token = ?0;", t.tableName) | ||
| query := fmt.Sprintf("DELETE FROM %s WHERE token = ?0;", game+"_"+platform) |
There was a problem hiding this comment.
omg, we need to be sure @guilhermef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listens to multiple queues and routes the message to the desired app.