Add metric support to Feedback Listener #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 12, 2019 15:58
…DStatsd; add related tests; update tests to use Counts map instead of Count due to name conflict
…ack-listener-metrics
…ack-listener-metrics
…ge to create topics only once; use different consumer groups per test
|
@mbotarro actually the env var is |
cscatolini
suggested changes
Feb 19, 2019
feedback/listener.go
Outdated
| @@ -80,13 +93,13 @@ func (l *Listener) configure() error { | |||
| } | |||
| l.Queue = q | |||
|
|
|||
| broker, err := NewBroker(l.Logger, l.Config, q.MessagesChannel(), l.Queue.PendingMessagesWaitGroup()) | |||
| broker, err := NewBroker(l.Logger, l.Config, nil, q.MessagesChannel(), l.Queue.PendingMessagesWaitGroup()) | |||
There was a problem hiding this comment.
I think we'd better send StatsReporters instead of nil in here.
feedback/listener.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("error creating new broker: %s", err.Error()) | ||
| } | ||
| l.Broker = broker | ||
|
|
||
| handler, err := NewInvalidTokenHandler(l.Logger, l.Config, l.Broker.InvalidTokenOutChan) | ||
| handler, err := NewInvalidTokenHandler(l.Logger, l.Config, nil, l.Broker.InvalidTokenOutChan) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds support to
StatsReporterin theListener,BrokerandInvalidTokenHandler.The
Listenerperiodically flushes the pipeline channels’ size as a gauge metric. The flush interval can be set using the new env variablePUSHER_STATS_FLUSH_S.The
InvalidTokenHandlersends metrics related to the tokens deletion. Its unit tests have been updated using aStatsDmock.Beyond that, the following modifications have been introduced:
Countmethod has been added in theStatsdInterface and its mock has been updated since there was aCountfield that caused a conflictStatsDandStatsReporterinterface to send genericGaugeandCountmetrics with a game and platform as tagsRowsAffectedin the result. To solve that, the mock has been updated to put anullcharacter at the end of the query in a way that theNewResultfunction is now able to correctly parse it.common.gofile was created to manage the reporters initialisation and use