Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse repository subgroup correctly #783

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

Papooch
Copy link
Contributor

@Papooch Papooch commented Jul 20, 2023

Description

Fixes the parseRepositoryProperty function to correctly parse repository urls if there are multiple subgroups in it.

Related Issues

Relates to #782

Checklist

  • I agree to abide by the Code of Conduct.
  • I have updated the relevant gatsby files (documentation).
  • This PR has sufficient test coverage.
  • This PR title satisfies semantic convention.

Additional Comments

No additional comments.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #783 (1de5c22) into main (3b0d590) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #783   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files          54       54           
  Lines        1489     1489           
  Branches      359      359           
=======================================
  Hits         1421     1421           
  Misses         68       68           

@noahnu noahnu self-assigned this Jul 20, 2023
@noahnu noahnu merged commit 58cc2a7 into tophat:main Jul 20, 2023
9 of 11 checks passed
@noahnu
Copy link
Contributor

noahnu commented Jul 20, 2023

@all-contributors add @Papooch for code, docs

@allcontributors
Copy link
Contributor

@noahnu

I've put up a pull request to add @Papooch! 🎉

@Papooch Papooch deleted the fix/parse-repository-property branch July 21, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants