This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
feat: add undo yvm effects on the shell commands #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamogbz
changed the title
noahnu
reviewed
Jun 11, 2019
| @@ -1,6 +1,9 @@ | |||
| import os from 'os' | |||
| import path from 'path' | |||
| import fs from 'fs' | |||
| import { negate } from 'lodash' | |||
There was a problem hiding this comment.
Suggested change
| import { negate } from 'lodash' | |
| import negate from 'lodash/negate' |
noahnu
reviewed
Jun 11, 2019
| export const getPathEntries = shell => | ||
| getCurrentPath(shell).split(getPathDelimiter(shell)) | ||
|
|
||
| export const getNonYvmPathEntries = shell => | ||
| getPathEntries(shell).filter(negate(isYvmPath)) |
There was a problem hiding this comment.
why use a function for negation?
There was a problem hiding this comment.
I like the way it looks
|
🎉 This PR is included in version 3.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
deactivateandunloadcommandsChecklist
DevQA
DevQA Prep
make install-watchDevQA Steps
unloadecho $YVM_DIRshould show the location of yvmwhich yarnshould point to the shimmed yvm yarnyvm unloadwhich yarnshould point to the system installed yarn or nothing if noneecho $YVM_DIRshould show nothingyvm useshould faildeactivateecho $YVM_DIRshould show the location of yvmwhich yarnshould point to the shimmed yvm yarnyvm deactivatewhich yarnshould point to the system installed yarn or nothing if noneecho $YVM_DIRshould still show yvm locationyvm usewhich yarnshould point to the version of yarn in your.yvmrcfileComments