Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change ad set
is_autobid
parameter default to nil
(was true
)
This is a breaking change for current users of this library, but I think it's essential for moving forward. Rationale: - The previous behavior (defaulting to true) is not aligned with how the official FB SDK works, which is not opinionated about default parameter values. We shouldn't be opinionated this way either. - In the future we want to support the `bid_amount` parameter. However with `is_autobid` defaulting to true, if someone were to pass `bid_amount` without explicitly turning off autobid, the request would fail. That seems like an obvious developer trap that we can avoid by making users be explicit about autobid when they want it. Normally a breaking change like this would require a major version number increment, but since we're on major version 0 the public API is not expected to be stable, so I plan to just bump the minor version number.
- Loading branch information