fix: revert docker stack to IBFT and fix a few commands #13

sebastiendan · 2023-03-26T11:07:01Z

Description

Fix a few things w.r.t. the docker/local-topos stack.

Add missing --chain-id flag in PolyBFT manifest file generation
Reset Dockerfile to work with ibft instead of polybft (still waiting for Polygon documentation to fully grasp what polybft revolves around—seems to be for supernets only)
Change recursively /data folder's permissions to allow for read and unit tests later
Re-use cd /data strategy for ibft genesis file generation (from docker/local)

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added or updated tests that comprehensively prove my change is effective or that my feature works

fix: add chain-id in manifest command

d6cc39c

sebastiendan force-pushed the fix/update-topos-docker branch 3 times, most recently from a930cb1 to e56159a Compare March 26, 2023 13:45

fix: test building ibft image

30e07e3

sebastiendan force-pushed the fix/update-topos-docker branch from e56159a to 30e07e3 Compare March 26, 2023 15:19

sebastiendan added 2 commits March 26, 2023 17:30

fix: chmod /data for ibft too

c05bfa9

chore: clean docker workflow

2ee16e4

sebastiendan marked this pull request as ready for review March 27, 2023 08:26

sebastiendan requested review from a team as code owners March 27, 2023 08:26

sebastiendan requested review from hadjiszs, atanmarko and foo0x29a March 27, 2023 08:26

sebastiendan changed the title ~~fix: add chain-id in manifest command~~ fix: revert docker stack to IBFT and fix a few commands Mar 27, 2023

atanmarko approved these changes Mar 27, 2023

View reviewed changes

sebastiendan merged commit d473f18 into develop Mar 27, 2023

sebastiendan deleted the fix/update-topos-docker branch March 27, 2023 09:00

atanmarko pushed a commit that referenced this pull request Aug 18, 2023

fix: revert docker stack to IBFT and fix a few commands (#13)

8211a58

atanmarko pushed a commit that referenced this pull request Sep 7, 2023

fix: revert docker stack to IBFT and fix a few commands (#13)

97f145f

atanmarko pushed a commit that referenced this pull request Sep 15, 2023

fix: revert docker stack to IBFT and fix a few commands (#13)

a4de796

atanmarko pushed a commit that referenced this pull request Oct 9, 2023

fix: revert docker stack to IBFT and fix a few commands (#13)

73d7928