Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VS Code devcontainer config #178

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Add VS Code devcontainer config #178

merged 1 commit into from
Jan 24, 2022

Conversation

bcdickinson
Copy link
Collaborator

@bcdickinson bcdickinson commented Jan 24, 2022 •
edited
Loading

Description

Adds a simple VS Code devcontainer setup for this project based on the existing docker-compose setup.

Closes #173

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added an appropriate CHANGELOG entry

@bcdickinson bcdickinson self-assigned this Jan 24, 2022
@bcdickinson bcdickinson marked this pull request as draft January 24, 2022 11:27
@bcdickinson bcdickinson marked this pull request as ready for review January 24, 2022 12:11
thibaudcolas
thibaudcolas approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcdickinson gave this a quick look, all seems fine to me. I’ll try running this locally once it’s merged 😬 .

CONTRIBUTING.md Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@thibaudcolas thibaudcolas added the enhancement New feature or request label Jan 24, 2022
@bcdickinson bcdickinson force-pushed the chore/devcontainer branch 2 times, most recently from 408b4e7 to 897315e Compare January 24, 2022 15:20
@bcdickinson bcdickinson merged commit dbdc547 into main Jan 24, 2022
@bcdickinson bcdickinson deleted the chore/devcontainer branch January 24, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaudcolas thibaudcolas thibaudcolas approved these changes

Assignees

@bcdickinson bcdickinson

Labels
enhancement New feature or request
Projects
No open projects
django-pattern-library v1.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSCode Devcontainer configuration
2 participants
@bcdickinson @thibaudcolas