Skip to content

fix: make it work for django5.0 (updated) #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

fix: make it work for django5.0 (updated) #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9a8b36
fix: make it work for django5.0
llPekoll Dec 16, 2023
6cd2990
Update CHANGELOG
alxbridge Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
python-version: "3.11"
cache: 'poetry'
- run: pip install tox
- run: tox -e lint,py311-dj42
- run: tox -e lint,py311-dj50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: test_compatibility below stats "Test with all supported Django versions, for all compatible Python versions." and includes 4.2 and main. Would be nice to update it to include 5.0, but that is not a blocker

test_compatibility:
needs: test
runs-on: ubuntu-latest
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Added

- Add support for Django 5.0 ([#241](https://github.com/torchbox/django-pattern-library/pull/241))

## [1.1.0](https://github.com/torchbox/django-pattern-library/releases/tag/v1.1.0) - 2023-10-25

### Added
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ classifiers = [
"Framework :: Django :: 3.2",
"Framework :: Django :: 4.1",
"Framework :: Django :: 4.2",
"Framework :: Django :: 5.0",
]
packages = [
{ include = "pattern_library" },
Expand All @@ -43,7 +44,7 @@ exclude = [

[tool.poetry.dependencies]
python = "^3.8"
Django = ">=3.2,<5.0"
Django = ">=3.2,<5.1"
PyYAML = ">=5.1,<7.0"
Markdown = "^3.1"

Expand Down
2 changes: 2 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ envlist =
py{38,39,310}-dj32
py{38,39,310,311}-dj41
py{38,39,310,311}-dj42
py{38,39,310,311}-dj50
py{310,311}-djmain
lint
skipsdist = true
Expand All @@ -20,6 +21,7 @@ deps =
dj32: Django>=3.2,<3.3
dj41: Django>=4.1,<4.2
dj42: Django>=4.2,<5.0
dj50: Django>=5.0,<5.1
djmain: https://github.com/django/django/archive/main.zip

[testenv:lint]
Expand Down