Skip to content

Conversation

nickmoreton
Copy link
Collaborator

@nickmoreton nickmoreton commented Mar 27, 2025

Support Ticket

Description of Changes Made

Upgrade Wagtail to v6.4.1

Updated:

  • Upgrading docs

Removed:

  • Un-used modeladmin templates: Please check I am right here...

Wagtail 6.4 release notes

Add a link to the commit or file for each consideration if you made any code changes.

Code reviewing a consideration.

Use the tick box to indicate a consideration has been code reviewed as OK

Upgrade considerations - changes affecting all projects

Upgrade considerations - changes affecting Wagtail customizations

Upgrade considerations - changes to undocumented internals

How to Test

Screenshots

Expand to see more

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

Bump Django to 5.1.7
Upgrade poetry to 1.8.5
Add pre-commit hook to keep poetry.lock in sync with pyproject.toml
Copy link
Collaborator Author

@nickmoreton nickmoreton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check that these templates are no longer used.

abe5653

Copy link
Collaborator

@JakubMastalerz JakubMastalerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of notes from me

@ianmeigh ianmeigh marked this pull request as ready for review April 8, 2025 08:44
@ianmeigh ianmeigh merged commit cf5afaa into main Apr 14, 2025
6 checks passed
@ianmeigh ianmeigh deleted the support/wagtail-64-upgrade branch April 14, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants