Allow wagtail 4 #42
Allow wagtail 4 #42
Conversation
wagtail_footnotes/templates/wagtail_footnotes/admin/footnotes_modal.html
Show resolved
Hide resolved
|
8fd956e is to bring back the template and javascript file that works with 2.15, 2.16 & 3.0 |
wagtail_footnotes/urls.py
Outdated
| from wagtail import VERSION as WAGTAIL_VERSION | ||
|
|
||
| if WAGTAIL_VERSION >= (4, 0): | ||
| template_name = "wagtail_footnotes/admin/footnotes_modals.html" |
|
Thanks for putting this together @nickmoreton! I've tested this with Wagtail 4 and we now have it running in production (with the patch to fix the template name typo). I unfortunately do not have time to test older versions of Wagtail. I do want to note that there are UI/UX issues in Wagtail 4 where it is nearly impossible to add a footnote using the new hidden-by-default rich text toolbar. I've reported the basic issue upstream since this isn't really fixable in wagtail-footnotes, but wanted to detail the specifics here. Prior to Wagtail v4, it was possible to drop the cursor in the correct spot and simply select "Fn" from the always visible toolbar. With Wagtail v4, this workflow is now impossible, the toolbar is not activated:
As far as I know, it's only possible to make the toolbar visible after selecting something. If you select text, the toolbar appears but of course this will replace the selected word:
The only workaround I've found is to highlight a space:
This is not "discoverable" by non-tech editors. I only figured this out by watching the animated GIF in the "Extending the Draftail Editor" docs demonstrating a stock chooser. It also requires adding another space to replace the space replaced by the footnote reference when inserting footnotes mid-sentence. Hopefully this can be addressed upstream but in the meantime, should we add some documentation/screen shots to the README to make this more obvious? |
That sounds like a good solution for the moment. Your screen shots here are great, may be use those in the README. It could be pictorial introduction to the package. The third one shows exactly what you need to do. |
|
When can we expect this pull request to be included in the next release? Don't mean to rush the process - just trying to gauge how long it might take before we can start using this package with Wagtail 4. Thank you. |
|
@2qxtx I am sorry it is taking a while. You could pip install off this branch to continue work. |
They need an alternative template file and javascript file
nickmoreton
force-pushed
the
support/wagtail-4
branch
from
93131b4
to
78ffd6b
Compare
|
I've manually tested this on all Wagtail versions from 2.15 to 4.0.2 and all works as expected. It would be good to get some tests in place: #46 Also we should monitor this: #42 (comment) that has an upstream issue open: wagtail/wagtail#9281 |
This allows for Wagtail v4
Support ticket: https://projects.torchbox.com/projects/support-team/tickets/591
Adjustments were required in Javascript and templates to pick up new css selectors and styling.