E2E test: torrent download #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test register a new user (we have not share the same account so far). The newly generated user remains in the database after executing the test. This commit cleans the database removing the user.
josecelano
requested review from
mickvandijke
and removed request for
mickvandijke
|
Hi @mario-nt @grmbyrn, this is an example of E2E testing in the frontend app.
Hi @Wolfremium13, I do not like to clean the database running DELETE SQL queries because tests are coupled to the database implementation. For the torrents, there is an option in the UI to delete a torrent, but I do not know if it's a good idea to couple one test with another feature. Although we already have For the app users, there is no option in the app to delete users, so we do not have an alternative. We need to delete records in the inverse order of dependency between tables. With these changes the database should be empty after executing all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2E test for downloading a torrent file.
Subtasks