Fix bug for field change. (#119)

tortoise · Mar 3, 2021 · 5215127 · 5215127
1 parent 49897dc
commit 5215127
Show file tree

Hide file tree

Showing 6 changed files with 98 additions and 92 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 ### 0.5.1
 
 - Fix tortoise connections not being closed properly. (#120)
+- Fix bug for field change. (#119)
 
 ### 0.5.0
 

diff --git a/aerich/migrate.py b/aerich/migrate.py
@@ -281,9 +281,7 @@ def diff_models(cls, old_models: Dict[str, dict], new_models: Dict[str, dict], u
                                         and cls._db_version.startswith("5.")
                                     ):
                                         cls._add_operator(
-                                            cls._change_field(
-                                                model, new_data_field, old_data_field
-                                            ),
+                                            cls._modify_field(model, new_data_field),
                                             upgrade,
                                         )
                                     else:
@@ -376,13 +374,17 @@ def diff_models(cls, old_models: Dict[str, dict], new_models: Dict[str, dict], u
                                     upgrade,
                                 )
                         elif option == "db_field_types.":
-                            # change column
+                            # continue since repeated with others
+                            continue
+                        elif option == "default":
+                            # change column default
+                            cls._add_operator(cls._alter_default(model, new_data_field), upgrade)
+                        else:
+                            # modify column
                             cls._add_operator(
-                                cls._change_field(model, old_data_field, new_data_field),
+                                cls._modify_field(model, new_data_field),
                                 upgrade,
                             )
-                        elif option == "default":
-                            cls._add_operator(cls._alter_default(model, new_data_field), upgrade)
 
         for old_model in old_models:
             if old_model not in new_models.keys():

diff --git a/poetry.lock b/poetry.lock