New HTML5 input types #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2.forms into feature/html5-validators Conflicts: tests/test_widgets.py tw2/forms/widgets.py
| @@ -41,14 +105,14 @@ class PostlabeledInputField(InputField): | |||
| template = "tw2.forms.templates.postlabeled_input_field" | |||
|
|
|||
|
|
|||
| class TextField(InputField): | |||
| class TextField(HTML5KitchenSinkMixin, InputField): | |||
There was a problem hiding this comment.
Although I like that this approach is very universal usable, I don't like having all of the additional HTML5 attributes in a simple TextField. They might have a meaning on some of the types, but not on all of them. And automatically configuring validators would be quite impossible this way.
I'd rather just inherit the specific mixins in the specific field classes below for clarity.
Any opinions on that?
There was a problem hiding this comment.
agreed. better to not flood them.
Also clean up the class definitions and re-order them.
|
I'm happy now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17