Repository navigation
AI reviewer found issue in #712 #719
Closed
clemenslosbichler-cloud
started this conversation in
General
Replies: 2 comments
|
This seems like a legitimate issue to me, happy to review a PR fixing it. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
I think #712 dropped a case, and I'd rather flag it than sit on it.
In the new arm in compression_utils.rs, a non-trailers frame goes through
frame.into_data() and only errors when has_remaining() is true. An empty data
frame isn't caught by that, so it falls to Poll::Ready(None) and ends the body.
Before #712 that frame was forwarded and polling continued, so trailers arriving
after an empty data frame now get dropped. http_body says callers mustn't poll
after None, so they're gone for good.
Repro would be: compressed payload, then Frame::data(Bytes::new()), then
Frame::trailers(...), and assert the trailers still land.
Happy to be wrong about this if empty data frames aren't a case you care about.
How I found it, since it's relevant: I'm building an automated reviewer and I
ran it against a fork with #712 recreated on it. That's the whole reason I was
looking. If it's useful I'll open a proper issue with a failing test.
All reactions