fix: improve file detection #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qvalentin
reviewed
May 19, 2024
ftdetect/helm.vim
Outdated
| let filename = expand("%:t") | ||
| if filepath =~ '\v/(templates|charts)/.*\.(ya?ml|gotmpl|tpl|txt)$' | return 1 | en | ||
| if filename =~ '\v(helmfile).ya?ml' | return 1 | en | ||
| if getline(1) =~ '^apiVersion:' || getline(2) =~ '^apiVersion:' | return 1 | en |
There was a problem hiding this comment.
This would also set the filetype of normal kubernetes yaml files to helm. I'm not sure if this would be a problem.
There was a problem hiding this comment.
Maybe I could add a condition and only do this if the helm language server is installed. What do you think?
There was a problem hiding this comment.
I guess it's not really needed, I was just folloing an idea from #7 , I've removed it.
|
Thanks for the contribution! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #7 and #21