tox4: --colored is yes by default

[AntoineD]

With tox4a9, contrary to the docs --colored is yes by default.
What is the expected default?

[gaborbernat]

Yes, colored is on but default is the expected behaviour.

…

On Mon, 20 Dec 2021, 10:59 Antoine Dechaume, ***@***.***> wrote: With tox4a9, contrary to the docs <https://tox.wiki/en/rewrite/cli_interface.html#tox---colored> --colored is yes by default. What is the expected default? — Reply to this email directly, view it on GitHub <#2288>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFIQPQY26YMIWPVIKDGPODUR4EAXANCNFSM5KNMYS6Q> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[AntoineD]

Would you like a PR to fix the docs?

[gaborbernat]

Yes, please 👍

[AntoineD]

The default value is determined at runtime:

def add_color_flags(parser: ArgumentParser) -> None:
    converter = StrConvert()
    if converter.to_bool(os.environ.get("NO_COLOR", "")):
        color = "no"
    elif converter.to_bool(os.environ.get("FORCE_COLOR", "")):
        color = "yes"
    else:
        color = "yes" if sys.stdout.isatty() else "no"

    parser.add_argument(
        "--colored",
        default=color,
        choices=["yes", "no"],
        help="should output be enriched with colors",
    )

and for whatever reason when the doc is built the default is determined to be no.

We could change the doc build settings to match the expected default behavior, or hardcode the default to yes here and move the handling the env var and tty settings to a dedicated argparse.Action.
I prefer the second option, what's your opinion or do you see other options?

[gaborbernat]

We likely want to set FORCE_COLOR for the doc build 😊 in readthedocs. I like the current runtime logic and don't want to touch it.