/tox

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands executed by tox should be correctly quoted #851

Closed
gaborbernat opened this Issue Jun 21, 2018 · 0 comments

Comments

Assignees

@gaborbernat gaborbernat

Labels
Projects
None yet
Milestone
  3.4
1 participant
@gaborbernat
@gaborbernat
Member

gaborbernat commented Jun 21, 2018

Following the success of #845, we should make tox ran command displays from Python arrays to commands too. This should allow users to be able to easily debug without tox if one of those fail, by simply copy-pasting into the shell.

@gaborbernat gaborbernat added the feature:change label Jun 21, 2018

@gaborbernat gaborbernat added this to the 3.1 milestone Jun 21, 2018

@gaborbernat gaborbernat self-assigned this Jun 21, 2018

@gaborbernat gaborbernat referenced this issue Jun 21, 2018

Merged

[WIP] wheel support (and transitively PEP-518), plus pipe display failed commands #852

gaborbernat added a commit that referenced this issue Jun 29, 2018

@gaborbernat
[WIP] wheel support (and transitively PEP-518), plus pipe display fai… 
…led commands (#852)

#850 PEP-518 support: provide a tox configuration flag ``build`` which can be either ``sdist`` or ``wheel``. For ``sdist`` (default) we build the package as before by using ``python setup.py sdist``. However, when ``wheel`` is enabled now we'll use ``pip wheel`` to build it, and we'll also install wheels in these case into the environments. Note: ``pip`` 10 supports specifying project dependencies (such as ``setuptools-scm``, or a given ``setuptools`` version) via ``pyproject.toml``. Once ``pip`` supports building ``sdist`` to we'll migrate over the ``sdist`` build too.

#851 While running tox invokes various commands (such as building the package, pip installing dependencies and so on), these were printed in case they failed as Python arrays. Changed the representation to a shell command, allowing the users to quickly replicate/debug the failure on their own.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
731a962

@gaborbernat gaborbernat referenced this issue Jun 29, 2018

Closed

[wip] Pep 518 #861

@gaborbernat gaborbernat modified the milestones: 3.1, 3.2 Jul 8, 2018

@gaborbernat gaborbernat modified the milestones: 3.2, 3.4 Sep 14, 2018

gaborbernat added a commit to gaborbernat/tox that referenced this issue Sep 16, 2018

@gaborbernat
commands executed by tox should be correctly quoted #851
Verified
This commit was signed with a verified signature.
@gaborbernat gaborbernat Bernát Gábor
GPG key ID: 4FA18E063DB79989 Learn about signing commits
cc39780

@gaborbernat gaborbernat referenced this issue Sep 16, 2018

Merged

commands executed by tox should be correctly quoted #851 #987

@helpr helpr bot added the pr-available label Sep 16, 2018

@gaborbernat gaborbernat closed this in #987 Sep 16, 2018

gaborbernat added a commit that referenced this issue Sep 16, 2018

@gaborbernat
commands executed by tox should be correctly quoted #851
Loading status checks…
776a763

@helpr helpr bot added pr-merged and removed pr-available labels Sep 16, 2018

@gaborbernat gaborbernat referenced this issue Sep 19, 2018

Merged

Add pre and post commands #1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment