Fix env variable substitutions with defaults containing colon #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Join remaining parts of string instead of splitting on colon. * Add test with substitution default that contains a colon (URL). Fixes tox-dev#2182 Signed-off-by: Marco Weber <marco.weber@hotmail.de>
|
You'll need to add a changelog entry too 🤠 |
|
Thanks for the hint, wasn't sure if this applied on the rewrite branch. Over all, many thanks for the lightning fast responses, patience, pointing at solution - excellent experience for first-time contributors. |
gaborbernat
approved these changes
Aug 27, 2021
Codecov Report
@@ Coverage Diff @@
## rewrite #2186 +/- ##
========================================
Coverage 99.85% 99.85%
========================================
Files 157 157
Lines 8944 8948 +4
Branches 939 939
========================================
+ Hits 8931 8935 +4
Misses 3 3
Partials 10 10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Resolves #2182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marco Weber marco.weber@hotmail.de
Thanks for contributing a pull request!
If you are contributing for the first time or provide a trivial fix don't worry too
much about the checklist - we will help you get started.
Contribution checklist:
(also see CONTRIBUTING.rst for details)
in message body
<issue number>.<type>.rstfor example (588.bugfix.rst)<type>is must be one ofbugfix,feature,deprecation,breaking,doc,misc-- by :user:`<your username>`.CONTRIBUTORS(preserving alphabetical order)