Skip to content

Conversation

dconathan
Copy link
Contributor

@dconathan dconathan commented Jan 3, 2023

Resolves #2791.

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation (n/a)

This PR makes somewhat significant (?) changes to how extras are extracted from markers to accommodate situations where an extra falls into >2 extras groups (fixes #2791). The previous approach involved mutating the _markers list while iterating over it, which was problematic when dealing with longer lists. The new approach builds a new _markers list.

@dconathan
Copy link
Contributor Author

Resorted to some type: ignore fixes for mypy. I don't have much mypy experience so I'm open to feedback/suggestions for alternatives for those cases...

@gaborbernat gaborbernat force-pushed the 2791 branch 5 times, most recently from a1a56ce to 1588b35 Compare January 4, 2023 05:03
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
@gaborbernat gaborbernat merged commit 4578eaa into tox-dev:main Jan 4, 2023
descope bot referenced this pull request in descope/django-descope Jan 18, 2023
This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch |
`4.2.0` -> `4.2.1` | `4.3.4` (+11) |

---

### Release Notes

<details>
<summary>tox-dev/tox</summary>

### [`v4.2.1`](https://togithub.com/tox-dev/tox/releases/tag/4.2.1)

[Compare Source](https://togithub.com/tox-dev/tox/compare/4.2.0...4.2.1)

#### What's Changed

- update how extras are extracted to handle cases with more than 2
groups by [@&#8203;dconathan](https://togithub.com/dconathan) in
[https://github.com/tox-dev/tox/pull/2812](https://togithub.com/tox-dev/tox/pull/2812)

#### New Contributors

- [@&#8203;dconathan](https://togithub.com/dconathan) made their first
contribution in
[https://github.com/tox-dev/tox/pull/2812](https://togithub.com/tox-dev/tox/pull/2812)

**Full Changelog**: tox-dev/tox@4.2.0...4.2.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45OS4yIiwidXBkYXRlZEluVmVyIjoiMzQuOTkuMiJ9-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug with poetry and overlapping extras

2 participants