-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCE_LIBRARIES contains DRAWEXE #660
Comments
The obvious workaround is of course to manually remove DRAWEXE from OCEConfig.cmake, but certainly it should not get in there in the first place. For completeness, this is how the relevant part of the generated OCEConfig.cmake looks in my case:
|
Btw, the same problem seems to occur with earlier versions as well (e.g. I see it also with 0.14). |
Also the package "oce-draw 0.17.2-1" as shipped in Ubuntu 16.10 is affected. |
How important is this problem? It looks like the current oce in Debian is also affected. It is theoretically possible to fix it there before the next large stable release. Thanks |
Well, as mentioned it's easy to work around it, but it's still annoying. It should definitely be fixed for the next release. Here is a suggestion for a simple fix: diff --git a/CMakeLists.txt b/CMakeLists.txt
index dd56a4d..eba6380 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -990,7 +990,8 @@ macro(process_module modulename modules_std)
list(APPEND modules ${ARGN})
endif(NOT OCE_DISABLE_X11)
foreach(module ${modules})
- list(APPEND OCE_LIBRARIES ${module})
+ if(NOT module MATCHES ".*EXE")
+ list(APPEND OCE_LIBRARIES ${module})
+ endif()
set(TOOLKIT_MODULES "")
set(TOOLKIT_DEPENDS "")
set(TOOLKIT_INCLUDE_DIRECTORIES "") |
The branch is merged (thanks for that!). Closing the issue ... |
* see issue tpaviot#660 (cherry picked from commit 3407813)
* see issue tpaviot#660 (cherry picked from commit 3407813)
Hi,
I have successfully built OCE 0.18 with -DOCE_DRAW=ON. Now, if I want to link my own application to OCE via
I get:
It seems that OCE_LIBRARIES wrongly includes DRAWEXE (which obviously is not a library).
Hope it's not a big deal to fix this ...
Cheers,
Janus
The text was updated successfully, but these errors were encountered: