Fix clock_gettime detection on osx #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xzcvczx that sounds ok, I was about to push the same fix. Waiting for travis and appveyor builds to complete before merging |
|
oh my bad, wasn't sure when you would get a chance to do it so thought i might try and help out |
|
@xzcvczx Can u please rebase your branch onto master ? I updated the travis build so that osx is part of the test. Travis runs an old xcode version, we can check if your fix passes on a system without clock_gettime |
|
Can I do something to help get this merged? |
|
yeah sorry, do you want to fix up the patch so it merges cleanly, I have
just been very busy recently and have no time to do anything with it
thanks
…On 16 March 2017 at 00:05, John T. Foster ***@***.***> wrote:
Can I do something to help get this merged?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#654 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACr4PLqQ72i0U1KxHteidTfaRdbae1IMks5rl8YQgaJpZM4LqB6E>
.
--
<a href="www.google.com/">hello</a>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should future proof the clock_gettime detection and whether to include gettime_osx.h on OSX. I have been unable to test on a system without clock_gettime so it should probably be checked