Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markers should show on all maps of same dimension #71

Closed
tpwalke2 opened this issue Aug 25, 2024 · 1 comment
Closed

Markers should show on all maps of same dimension #71

tpwalke2 opened this issue Aug 25, 2024 · 1 comment
Labels
1.21-0.4.0 Will be added in the 1.21-0.4.0 release enhancement New feature or request

Comments

@tpwalke2
Copy link
Owner

Discovered while researching #67

If a given dimension has multiple maps configured in BlueMap, the markers will only show in one of them.

BlueMapSignMarkers/src/main/java/com/tpwalke2/bluemapsignmarkers/core/bluemap/BlueMapAPIConnector.java

Line 175 in 4878268

return maps.stream().findFirst();
returns only the first map for the given world.
@tpwalke2 tpwalke2 added bug Something isn't working 1.21-0.4.0 Will be added in the 1.21-0.4.0 release labels Aug 25, 2024
@tpwalke2 tpwalke2 changed the title Markers do not show for all maps of same dimension Markers should show on all maps of same dimension Aug 26, 2024
@tpwalke2 tpwalke2 added enhancement New feature or request and removed bug Something isn't working labels Aug 26, 2024
tpwalke2 added a commit that referenced this issue Sep 2, 2024
@tpwalke2
#71 Markers should be added to all maps for given dimension
fa245e4
tpwalke2 added a commit that referenced this issue Sep 2, 2024
@tpwalke2
Merge pull request #77 from tpwalke2/71-multiple-maps
f640d5e 
#71 Markers should be added to all maps for given dimension
@tpwalke2
Copy link
Owner Author

tpwalke2 commented Sep 2, 2024

I have merged the PR (#77) for this update to main.

There are a few other items I am targeting for the same version (1.21-0.4.0), however. You can track the progress of those issues here: https://github.com/tpwalke2/BlueMapSignMarkers/issues?q=is%3Aissue+is%3Aopen+label%3A1.21-0.4.0

@tpwalke2 tpwalke2 closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.21-0.4.0 Will be added in the 1.21-0.4.0 release enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpwalke2