Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing prefix to no longer match does not remove marker from map #73

Closed
tpwalke2 opened this issue Aug 25, 2024 · 1 comment
Closed

Changing prefix to no longer match does not remove marker from map #73

tpwalke2 opened this issue Aug 25, 2024 · 1 comment
Labels
1.21-0.4.0 Will be added in the 1.21-0.4.0 release bug Something isn't working

Comments

@tpwalke2
Copy link
Owner

Steps:

  1. Use the default configuration with a [poi] prefixed marker group.
  2. Add a sign in-game with the prefix [poi].
  3. Verify that the marker appears on BlueMap.
  4. Edit the sign and change the prefix to [poI].

Expected:

  • Marker is removed from BlueMap.
  • Marker is not loaded after server restart.

Actual

  • Marker remains on BlueMap.
  • Marker is loaded after server restart.
@tpwalke2 tpwalke2 added bug Something isn't working 1.21-0.4.0 Will be added in the 1.21-0.4.0 release labels Aug 25, 2024
tpwalke2 added a commit that referenced this issue Sep 2, 2024
@tpwalke2
#73 Move signs to new group when prefix changes
04b04de
tpwalke2 added a commit that referenced this issue Sep 2, 2024
@tpwalke2
Merge pull request #79 from tpwalke2/73-update-prefix-changes
6c3ae9c 
#73 Move signs to new group when prefix changes
@tpwalke2
Copy link
Owner Author

tpwalke2 commented Sep 2, 2024

I have merged the PR (#79) for this update to main.

There are a few other items I am targeting for the same version (1.21-0.4.0), however. You can track the progress of those issues here: https://github.com/tpwalke2/BlueMapSignMarkers/issues?q=is%3Aissue+is%3Aopen+label%3A1.21-0.4.0

@tpwalke2 tpwalke2 closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.21-0.4.0 Will be added in the 1.21-0.4.0 release bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpwalke2