Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the wp-interpolant algorithm #381

Closed
wants to merge 74 commits into from
Closed

Conversation

rasoolmaghareh
Copy link
Member

No description provided.

@rasoolmaghareh
Copy link
Member Author

@ArpitaDutta @sanghu1790 The commit "Function argument mapping" is adding a lot of files in Debug+ Assert folder. These are binary files and they should be removed. Also I am seeing some .setting files being added, these files are generated during build and should not be checked in.

@ArpitaDutta
Copy link
Member

ArpitaDutta commented Sep 6, 2021 via email

@rasoolmaghareh
Copy link
Member Author

Please check the changes that are added and remove all the files which are added in the commits and are in Debug+Assert folder.

Hii Rasool, How can I help in this? Regards, Arpi

@ArpitaDutta
Copy link
Member

ArpitaDutta commented Sep 6, 2021 via email

@rasoolmaghareh
Copy link
Member Author

Thanks @ArpitaDutta for removing Debug+Assert and Release+Assert from the main directory. However, there are still many Debug+Assert and Release+Assert folders left in the subdirectories like Core\Debug+Assert and Solver\Debug+Assert. Can you please remove those too? You can see a full list when clicking the Files Changed Tab in this pull request(PR).

@ArpitaDutta
Copy link
Member

ArpitaDutta commented Sep 7, 2021 via email

@rasoolmaghareh
Copy link
Member Author

Closing this pull request, since the code got merged separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants