-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-format, restructure project for CI #50
Conversation
Add a Linux CI target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the small nit, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we should add something in the README about using make lint
to make sure code is formatted correctly.
Might be useful to add a make format
that actually fixes the linter too.
Will do!
This shouldn't be necessary, since |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool. Would prefer formatting to be manually done with a command for sanity checking.
Ahhh, right. Haha forgot that |
Yep, I've added a README note to that effect.
It actually does, but the check option doesn't return an exit code either. One day I'll submit that patch 😉. |
Add a Linux CI target.