Bugfix for validate() #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the schema dependencies, I got the exception:
TypeError: Parameter 'url' must be a string, not number
at Url.parse (url.js:107:11)
at urlParse (url.js:101:5)
at Object.urlResolve [as resolve] (url.js:404:10)
at Validator.addSubSchema (/.../node_modules/express-jsonschema/node_modules/jsonschema/lib/validator.js:61:36)
at Validator.addSchema (/.../node_modules/express-jsonschema/node_modules/jsonschema/lib/validator.js:42:8)
at Array.forEach (native)
at validate (/.../node_modules/express-jsonschema/index.js:164:28)
at Object.<anonymous>
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
This is caused by: schemaDependencies.forEach(callBack)
-> The callback takes element value, index, and array. This gets bind to the addSchema function, which will lead to a wrong uri.
As can be seen from the original implementation of the addSchema function:
https://github.com/tdegrunt/jsonschema/blob/master/lib/validator.js#L37
Changing this to a normal for-loop fixes the issue.
|
The error reports don't seem to be correlated with my changes, right? |
|
I had the same issue and have the same solution . |
|
Would be great if this fix was merged. Without this fix having more than a single schema dependency does not work. |
|
@trainiac will this be merged? |
|
I am getting the same issue... Will this fix be merged? |
|
Hey all! Sorry for the delay. I took a year off but am back now and will be responding to any issues as they come in now. I'll take a look at this and get it merged ASAP. |
tkirda
reviewed
Sep 27, 2016
| schemaDependencies.forEach(validator.addSchema.bind(validator)); | ||
| for(var i = 0; i < schemaDependencies.length; i++) { | ||
| validator.addSchema(schemaDependencies[i]); | ||
| } |
There was a problem hiding this comment.
This could be simpler:
schemaDependencies.forEach(function (dependency) {
validator.addSchema(dependency);
});
|
This will be fixed here #15 |
|
@trainiac thanks! |
|
1.1.5 is on npm now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the schema dependencies, I got the exception:
TypeError: Parameter 'url' must be a string, not number
at Url.parse (url.js:107:11)
at urlParse (url.js:101:5)
at Object.urlResolve as resolve
at Validator.addSubSchema (/.../node_modules/express-jsonschema/node_modules/jsonschema/lib/validator.js:61:36)
at Validator.addSchema (/.../node_modules/express-jsonschema/node_modules/jsonschema/lib/validator.js:42:8)
at Array.forEach (native)
at validate (/.../node_modules/express-jsonschema/index.js:164:28)
at Object.
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
This is caused by: schemaDependencies.forEach(callBack)
-> The callback takes element value, index, and array. This gets bind to the addSchema function, which will lead to a wrong uri.
As can be seen from the original implementation of the addSchema function:
https://github.com/tdegrunt/jsonschema/blob/master/lib/validator.js#L37
Changing this to a normal for-loop fixes the issue.