More flexible filename handling #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for issue transcript#81. In a nutshell, sample names are now extracted more precisely from filenames so that file naming can be more flexible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #81, where
run_DESeq_stats.RandSubsystems_DESeq_stats.Rwill fail if filenames do not follow the patternexperimental_#_...orcontrol_#_....Rather than splitting the filenames by underscores, the new code removes
experimental_orcontrol_from the beginning and.cleanedfrom the end in order to get the sample names for matching.Also, I solved the problem of R wanting to change the counts to factors by setting the sample names as row names before transposing. (Previously, if the sample names were not numeric, transposing the dataframe would create columns that were mixed so R would convert all columns to factors. Pulling the sample names into the row names before transposing allows them to directly become column names without affecting the data types.)
Thank you and let me know if you have any questions!