-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@uppy/dashboard: update provider icon style #4345
Conversation
It's not needed now since we removed colorful circles behind the service icons
To play better with the new icon style
Looking good! Thanks for the quick turnaround again! Not sure about Dropbox: seems out of place in dark mode, as it’s the only white one. I also feel like I might want the margins around icons a bit bigger, meaning bigger background layer under them, like what you’ve shown before: But I go back and forth on that last one, maybe I just need time to adjust, we can tweak this easily later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for picking this up!
| Package | Version | Package | Version | | -------------------- | ------- | -------------------- | ------- | | @uppy/audio | 1.1.0 | @uppy/onedrive | 3.1.0 | | @uppy/box | 2.1.0 | @uppy/provider-views | 3.1.0 | | @uppy/core | 3.1.0 | @uppy/screen-capture | 3.1.0 | | @uppy/dashboard | 3.3.0 | @uppy/unsplash | 3.1.0 | | @uppy/dropbox | 3.1.0 | @uppy/url | 3.2.0 | | @uppy/facebook | 3.1.0 | @uppy/utils | 5.1.3 | | @uppy/google-drive | 3.1.0 | @uppy/webcam | 3.3.0 | | @uppy/image-editor | 2.1.1 | @uppy/zoom | 2.1.0 | | @uppy/instagram | 3.1.0 | uppy | 3.6.0 | | @uppy/locales | 3.0.7 | | | - @uppy/locales: add missing entries after build (Murderlon) - @uppy/dashboard: update provider icon style (Alexander Zaytsev / #4345) - @uppy/core: fix uppy.resetProgress() (Artur Paikin / #4337) - @uppy/core: fix some types (Antoine du Hamel / #4332) - @uppy/core: Fixed type of State.info to match reality being an array of info objects (Marc Bennewitz / #4321) - @uppy/image-editor: Fix TypeScript error in image-editor types (Matthias Kunnen / #4334) - meta: improve `importFromUploadURLs` docs (Mikael Finstad / #4323) - @uppy/utils: workaround chrome crash (Mikael Finstad / #4310)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't belong there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are we doing in this old PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git blame? 😄
It seems Google now only allows using their full-color Google Drive logo, and doesn't offer any monochrome logo. We can't use the one-color logo any more.
To fix that, I redesigned all the icons, and used the white background for all of them so that we can easily use the new Google Drive logo. Here's how the new version looks:
Dark mode:
Authentication step:
This closes #3153.