Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/svelte: use ESM as export format #4492

Closed
wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 9, 2023

Breaking change so no rush here.
We probably want to switch to Vite instead of Rollup on the example.

@socket-security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Install scripts svelte-preprocess 5.0.4
  • Install script: postinstall
  • Source: echo "[svelte-preprocess] Don't forget to install the preprocessors packages that will be used: sass, stylus, less, postcss & postcss-load-config, coffeescript, pug, etc..."
examples/svelte-example/package.json via svelte-check@3.4.3, packages/@uppy/svelte/package.json

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore svelte-preprocess@5.0.4

@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
typescript 🆕 5.1.3 None +0 40.1 MB typescript-bot
@rollup/plugin-json 🆕 6.0.0 None +1 45.7 kB shellscape
svelte-preprocess 🆕 5.0.4 None +5 41.4 MB dummdidumm
@rollup/plugin-node-resolve 🆕 15.1.0 None +4 185 kB shellscape
sirv-cli ⬆️ 1.0.14...2.0.2 None +2/-2 46.6 kB lukeed
rollup-plugin-css-only ⬆️ 3.1.0...4.3.0 None +1/-0 48.9 kB thgh
@rollup/plugin-typescript ⬆️ 8.5.0...11.1.1 None +2/-0 40.2 MB shellscape
@rollup/plugin-commonjs ⬆️ 22.0.2...25.0.0 None +2/-0 624 kB shellscape
svelte-check ⬆️ 1.6.0...3.4.3 None +4/-0 49.5 MB svelte-language-tools-deploy

🚮 Removed packages: @tsconfig/svelte@1.0.13

Footnotes

  1. https://docs.socket.dev

@aduh95 aduh95 added the 4.0 For the 4.0 major version label Jun 16, 2023
@arturi arturi mentioned this pull request Aug 14, 2023
@aduh95
Copy link
Contributor Author

aduh95 commented Jun 3, 2024

Superseded by #5023

@aduh95 aduh95 closed this Jun 3, 2024
@aduh95 aduh95 deleted the svelte-esm branch June 3, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.0 For the 4.0 major version pending end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant