Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@uppy/core: add clearUploadedFiles to type definition #5295

Merged

Conversation

The-Flash
Copy link
Contributor

Hello Team,

Even though the clearUploadedFiles in the uppy/core method is documented on the doc site, it is not accessible outside.
Upon investigation, I realized it is not present in index.d.ts.

This PR adds the method to the index.d.ts file along with some unit tests for said method.

@The-Flash The-Flash marked this pull request as ready for review July 2, 2024 10:04
@The-Flash The-Flash changed the title add clearUploadedFiles to type definition @uppy/core: add clearUploadedFiles to type definition Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Diff output files
No diff

Copy link
Member

@Murderlon Murderlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, on Uppy 4.0 (currently in beta) this is renamed to clear and is properly typed. But it's nice to backport it (on 3.x the manual types are still used, even though the source is in TS).

@aduh95 aduh95 merged commit 6f889ec into transloadit:main Jul 2, 2024
17 checks passed
This was referenced Jul 2, 2024
github-actions bot added a commit that referenced this pull request Jul 2, 2024
| Package                | Version | Package                | Version |
| ---------------------- | ------- | ---------------------- | ------- |
| @uppy/companion        |  4.15.0 | @uppy/drag-drop        |   3.1.1 |
| @uppy/companion-client |   3.8.2 | @uppy/form             |   3.2.2 |
| @uppy/core             |  3.13.1 | uppy                   |  3.27.2 |

- @uppy/form: do not emit `'submit'` event more than once (Merlijn Vos / #5299)
- @uppy/companion: add `s3.forcePathStyle` option (Nadeem Reinhardt / #5066)
- meta: fix broken workflow status badges in README (Alexander Zaytsev / #5298)
- @uppy/core: add `clearUploadedFiles` to type definition (Augustine Smith / #5295)
- @uppy/companion: add `oauthOrigin` option (Antoine du Hamel / #5297)
- meta: add dark-mode Transloadit logo in README (Alexander Zaytsev / #5291)
- docs,@uppy/drag-drop: `uppy.io/docs` - fix typos/broken links (Evgenia Karunus / #5296)
- meta: Bump docker/build-push-action from 6.1.0 to 6.2.0 (dependabot[bot] / #5290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants