-
Notifications
You must be signed in to change notification settings - Fork 32
Make configure compatible with PHP 7.4 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The libonig issue still needs to be resolved I think.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the use of :
$TRAVIS_BUILD_DIR/default_configure_options.${RELEASE}
in the install files, and the use of default_configure_options.trusty-master
style configure files, it might be best to use the custom_configure_options
file and then add them to the default file used.
there is an issue with the version of Console_Getopts packaged with PEAR, it packages an old version which uses the each method, which is removed in 8.0
Why are you disabling PEAR on master? It should be compatible with PHP 8. At least the Console_GetOpt issue you're referencing was fixed a few weeks ago. |
hey @nikic, I did lots of testing but it seems as though the version of Console_Getopt packaged in PEAR is old and does not include the |
@@ -0,0 +1,49 @@ | |||
--enable-intl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this one also need all the version specific variations, at least for baseline, 7.4, master? (Which is also the reason why I still think that #29 is a more scalable solution to this problem.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, i borrowed this from the xenial base line default for my testing.
@joshk Just tested this locally and you are absolutely right. This must be a recent regression as this was working a few days ago :/ I'll try to get this fixed. |
awesome, thanks @nikic |
I have to admit that I hijacked this PR a little to test some build system improvements. Once this gets merged in I can create a PR with my tweaks. |
@@ -7,7 +7,7 @@ travis_time_start | |||
|
|||
if [[ ! $VERSION =~ ^7 && ! $VERSION =~ ^master$ ]]; then | |||
pecl download memcache-beta | |||
tar zxvf memcache*.tgz && pushd memcache* | |||
tar zxvf memcache*.tgz && pushd memcache*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these trailing slashes for?
Forgot to report back here, the go-pear.phar issue has been resolved (again...) so it should be fine to also install on master. |
Also in the meantime |
This is a followup to #29 using separate config files as requested by @BanzaiMan