Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linter: Enable linter on lib #98

Merged
merged 6 commits into from
Feb 24, 2023
Merged

linter: Enable linter on lib #98

merged 6 commits into from
Feb 24, 2023

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Feb 22, 2023 •
edited
Loading

Purpose

To improve the code quality of actual library sources.

Overview

  • Enabled standardb on lib sources but suppressed most of conventional-level checks. Will improve eventually.
  • Fixed one warning-level chekc Lint/Loop

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@github-actions github-actions bot added the doc label Feb 22, 2023
@exoego exoego marked this pull request as ready for review February 22, 2023 12:07
@exoego exoego requested a review from a team as a code owner February 22, 2023 12:07
@exoego exoego added chore non user-facing trivial stuff (CI, refactoring, etc) and removed doc labels Feb 22, 2023
yuokada
yuokada reviewed Feb 24, 2023
View reviewed changes
.standard_todo.yml
@@ -1,6 +1,32 @@
---
ignore:
- 'lib/trino/client/*.rb'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the target files are expanded.

I think it's enough to add the rules to the current target.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revereted

exoego
exoego commented Feb 24, 2023
View reviewed changes
.standard_todo.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the doc label Feb 24, 2023
exoego
exoego commented Feb 24, 2023
View reviewed changes
.standard_todo.yml Outdated Show resolved Hide resolved
yuokada
yuokada approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@yuokada yuokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ✅

@exoego exoego merged commit 1c043cd into master Feb 24, 2023
@exoego exoego deleted the lint-lib branch February 24, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuokada yuokada yuokada approved these changes

Assignees
No one assigned
Labels
chore non user-facing trivial stuff (CI, refactoring, etc) doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exoego @yuokada