node.isMissing() returns unexpected position

[skovhus]

I'm trying to use node.isMissing() for improving https://github.com/mads-hartmann/bash-language-server, but the startPosition and endPosition are off for the fi type below.

Example

if [[ $PATH_INPUT -nt $PATH_OUTPUT ]]; then
  babel --compact false ${PATH_INPUT} > ${PATH_OUTPUT}
f

echo "test"

The missing node will be shown after the echo statement, although I would expect it to fail at the position of f.

Any advice how to fix this?

[maxbrunsfeld]

The parser can't really tell where the fi should go. I think the only way it could guess that it was intended on line 10 is for it to know about formatting conventions like indentation, which it currently isn't aware of.

[skovhus]

Thanks for the quick reply. Wondering if we should simply show an error at the top or bottom of the file then with the missing node.

Closing this for now.