Add hooks for set type #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this PR! The file tests/test_set_import_nil.nim appears to be a duplicate of the other file. Please remove it for now and I'll merge this PR. We can take a look about |
|
Ok, done |
|
Thank you! Merged. |
|
I made some changes, I merge the test_set and test_sets file, and created my own version of SomeSet that includes set and just used that. ebee42e |
|
Ok, looks cleaner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a simple change - I've reused HashSet procs.
During testing I've found a bug with
from jsony import nilkonradmb@fd08c4e#diff-2d91982de276dc64eab6f65f18f163e2e279c6e977abb09c0511c7694312f868R73But you can ignore it for now as it's not connected to this change.