Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip pragma fixes #50 #51

Closed
wants to merge 1 commit into from
Closed

Conversation

creikey
Copy link

@creikey creikey commented Jul 20, 2022

Would close #50

@treeform
Copy link
Owner

Cool idea! Sorry I don't like the pragma approach:

  1. I liked the skip hook approach in the issue. I would like to keep everything on a single system - hook based.

  2. I feel like pragmas pollute the structure definition which might have nothing to do with JSON.

Also please add tests and also please make sure they pass even in JS mode.

@creikey
Copy link
Author

creikey commented Jul 23, 2022

Cool idea! Sorry I don't like the pragma approach:

  1. I liked the skip hook approach in the issue. I would like to keep everything on a single system - hook based.
  2. I feel like pragmas pollute the structure definition which might have nothing to do with JSON.

Also please add tests and also please make sure they pass even in JS mode.

Wouldn't the skip hook not run at compile time worsening performance because of the string compares?

@pietroppeter
Copy link
Contributor

this can be closed since #57 was merged

@treeform treeform closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy way to skip fields of an object
3 participants