feat: create Navbar component #582
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Matheus Benini Ferreira <88898100+MatheusBeniniF@users.noreply.github.com>
gitstart
changed the title
|
Hello @severinlandolt! Could you review this PR? There are other PRs here that are also ready for review it would be very interesting if you could help with the review, thanks. 😁 |
|
Hello @gitstart, I appreciate the pull request but I have to say no. Currently, we do not see any need for a dedicated NavBar component. I prefer to add a navbar to the page shell blocks rather than adding a new component very similar to the Tab. Nevertheless, thank you for your contribution! 🫶 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #284
Demo
https://www.loom.com/share/4d43ee76d6be467f8d42f88b8985280f
Test
What
create a new Navbar component#8
Why
for Tremor users to have a Navbar
How
The changes were implemented following the other component as a base, created a new folder on
layout-elementTesting
run:
and search for Navbar