This repository has been archived by the owner on Nov 16, 2021. It is now read-only.
bip32/nem: IV is copied before encryption #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsusanka
force-pushed
the
tsusanka/nem-encrypt-iv
branch
from
433e0f9
to
cf603f1
Compare
|
I don't think we'll ever need to encrypt the data in multiple calls, so this is probably fine 👍 |
tsusanka
added a commit
to trezor/trezor-mcu
that referenced
this pull request
Apr 4, 2018
The IV copy was moved to trezor-crypto (trezor/trezor-crypto#140) so it is not needed anymore in trezor-mcu
tsusanka
added a commit
to trezor/trezor-mcu
that referenced
this pull request
Apr 4, 2018
The IV copy was moved to trezor-crypto (trezor/trezor-crypto#140) so it is not needed in trezor-mcu anymore
tsusanka
added a commit
to trezor/trezor-mcu
that referenced
this pull request
Apr 4, 2018
The IV copy was moved to trezor-crypto (trezor/trezor-crypto#140) so it is not needed in trezor-mcu anymore
prusnak
pushed a commit
to trezor/trezor-mcu
that referenced
this pull request
Apr 4, 2018
The IV copy was moved to trezor-crypto (trezor/trezor-crypto#140) so it is not needed in trezor-mcu anymore
jcrona
pushed a commit
to archos-safe-t/safe-t-mcu
that referenced
this pull request
Jul 17, 2018
The IV copy was moved to trezor-crypto (trezor/trezor-crypto#140) so it is not needed in trezor-mcu anymore
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merged this can be removed from mcu https://github.com/trezor/trezor-mcu/blob/master/firmware/nem2.c#L267-L269
cc @saleemrashid