Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coins fee_thresholds #1192

Closed
tsusanka opened this issue Aug 17, 2020 · 7 comments · Fixed by #1223
Closed

Increase coins fee_thresholds #1192

tsusanka opened this issue Aug 17, 2020 · 7 comments · Fixed by #1223
Assignees
Labels
altcoin Any non-Bitcoin coins bitcoin Bitcoin related core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Milestone

Comments

@tsusanka
Copy link
Contributor

tsusanka commented Aug 17, 2020

As a follow-up of #1087 @mmilata made a great research with current fee threshold values of Bitcoin-like coins.

For some of the bitcoin-based coins, the threshold for 250B transaction is following:

Coin maxfee_kb fee_threshold USD rate fee_threshold (USD) hard limit (USD)
BTC 2000000 500000 sats = 0.005 11500.0 57.5 575
TEST 10000000 2500000 sats = 0.025 - - -
BCH 500000 125000 sats = 0.00125 280.0 0.4 4.0
BTG 500000 125000 sats = 0.00125 10.0 0.01 0.1
DASH 100000 25000 sats = 0.00025 90.0 0.02 0.2
DGB 500000 125000 sats = 0.00125 0.03 0.00004 0.0004
DOGE 1000000000 250000000 sats = 2.5 0.003 0.008 0.08
LTC 40000000 10000000 sats = 0.1 55.0 5.5 55.0
NMC 10000000 2500000 sats = 0.025 0.4 0.01 0.1
VTC 40000000 10000000 sats = 0.1 0.3 0.03 0.3
ZEC 1000000 250000 sats = 0.0025 85.0 0.2 2.0

Product suggests to set fee_threshold to $10 (and hard limit to $100 then) for all non-Bitcoin coins. For Bitcoin I would like to see some research and maybe we could set it to fivefold the average fee in the last year?

We brought up those numbers without any proper research whatsoever so any feedback is welcomed though. Let's discuss this in Triage.

@tsusanka tsusanka added core Trezor Core firmware. Runs on Trezor Model T and T2B1. bitcoin Bitcoin related altcoin Any non-Bitcoin coins discussion labels Aug 17, 2020
@tsusanka tsusanka added this to the backlog milestone Aug 17, 2020
@mmilata mmilata self-assigned this Aug 21, 2020
@tsusanka
Copy link
Contributor Author

Product suggests to set fee_threshold to $10 (and hard limit to $100 then) for all non-Bitcoin coins.

Is there any hard opposition to this? If not I suggest to do exactly that and leave Bitcoin as is for now cc @prusnak @matejcik.

I think we should do this asap and backport it into the September release - there is #1155 so just to make sure we do not break anything.

@mmilata could you look at this tomorrow?

@tsusanka tsusanka modified the milestones: backlog, 2020-09 Aug 23, 2020
@mmilata
Copy link
Member

mmilata commented Aug 23, 2020

@tsusanka sure

@prusnak
Copy link
Member

prusnak commented Aug 24, 2020

Is there any hard opposition to this?

I am OK with changing the fees for altcoins and not changing the fee values for Bitcoin.

@tsusanka
Copy link
Contributor Author

@mmilata could you please add Testnet into the table? Obviously without USD columns but it would be helpful to know the threshold also for Testnet.

@mmilata
Copy link
Member

mmilata commented Aug 24, 2020

@tsusanka added

@tsusanka
Copy link
Contributor Author

So @sorooris if you send between 0.025 and 0.25 TESTNET fee you should get a warning, if you send over 0.25 you should get an error.

@sorooris
Copy link
Contributor

sorooris commented Sep 1, 2020

QA OK
2.3.3 df5421e
Suite 3095a174f258c0226faf2ebcbdda3d8b7f04686f
image
image

0.18400039 TEST 0.25551594 TEST
image image

Wallet ec6b4d36cbae2ec1c3f479eb3c1891090790b7c0
Final fee: 100139.73493173493 sat/B
Size: 3.003 kB
Fee: 3.00719624 TEST
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
altcoin Any non-Bitcoin coins bitcoin Bitcoin related core Trezor Core firmware. Runs on Trezor Model T and T2B1.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants