Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@trezor/connect-popup: share browser detection code with suite #5324

Closed
2 tasks
szymonlesisz opened this issue May 4, 2022 · 1 comment · Fixed by #7844
Closed
2 tasks

@trezor/connect-popup: share browser detection code with suite #5324

szymonlesisz opened this issue May 4, 2022 · 1 comment · Fixed by #7844
Labels
code Code improvements connect Connect API related (ie. fee calculation)

Comments

@szymonlesisz
Copy link
Contributor

  • remove connect/src/utils/browserUtils
  • implement shared browser detection in @trezor/connect-popup and @trezor/connect-iframe
@szymonlesisz szymonlesisz added code Code improvements connect Connect API related (ie. fee calculation) labels May 4, 2022
@szymonlesisz szymonlesisz mentioned this issue May 4, 2022
Merged
42 tasks
@mroz22 mroz22 mentioned this issue Mar 14, 2023
Merged
@sime sime moved this to 🎯 To do in Issues Suite Mar 17, 2023
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Issues Suite Mar 23, 2023
@STew790
Copy link
Contributor

STew790 commented Apr 12, 2023

Talked to @mroz22 and this will be tested together with connect release.

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code Code improvements connect Connect API related (ie. fee calculation)
Projects
Issues Suite
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

connect: remove bowser dependency trezor/trezor-suite
3 participants
@szymonlesisz @mroz22 @STew790