Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@trezor/transport: fix in/out types #5332

Open
szymonlesisz opened this issue May 5, 2022 · 0 comments
Open

@trezor/transport: fix in/out types #5332

szymonlesisz opened this issue May 5, 2022 · 0 comments
Labels
code Code improvements connect Connect API related (ie. fee calculation)

Comments

@szymonlesisz
Copy link
Contributor

There is a lot of inconsistencies in types like:

TrezorDeviceInfoWithSession.session could be string | undefined | null but Transport.acquire > AcquireInput.pervious expects string | undefined
@szymonlesisz szymonlesisz added code Code improvements connect Connect API related (ie. fee calculation) labels May 5, 2022
@szymonlesisz szymonlesisz mentioned this issue May 5, 2022
Merged
42 tasks
@mroz22 mroz22 mentioned this issue Oct 10, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code Code improvements connect Connect API related (ie. fee calculation)
Projects
Issues Suite
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szymonlesisz