-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suite): label translations #9151
Conversation
@sime @Hermez-cz I find the copy somewhat confusing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, squash the commits into one.
I have some doubts regarding the design/copy, but code is fine.
64fb099
to
43ba1f3
Compare
@komret thank you for your feedbacks.
|
Let's move the Czech language to community languages please. That will leave us only with English in the official ones, but that will change soon. Czech language is translated very well, but by the community incl. our internal colleagues. We will move it to the official once it will be professionally proofread. |
Final & agreed solution:
|
I'm happy that this issue got a solution and community languages got closer to deployment. I've posted a question to TR_LANGUAGE_DESCRIPTION on Crowdin if the Nationality in the message should be translated to the selected country's nationality (eg. it's Cesky for Czech, magyar for Hungarian). I think that's the intention, right? Could someone from Trezor please add an answer there so that other translators may translate it accordingly? Thanks! |
Translations are divided into groups.
Description
Translations are divided into official and community group (grouping checked with @Hermez-cz). Removed group divider.
Added translation keys:
TR_LANGUAGE_DESCRIPTION
TR_LANGUAGE_CREDITS
TR_OFFICIAL_LANGUAGES
TR_COMMUNITY_LANGUAGES
Related Issue
Resolve #7624
Screenshots: