Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite): label translations #9151

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

AdamSchinzel
Copy link
Contributor

@AdamSchinzel AdamSchinzel commented Aug 11, 2023

Translations are divided into groups.

Description

Translations are divided into official and community group (grouping checked with @Hermez-cz). Removed group divider.

Added translation keys:

  • TR_LANGUAGE_DESCRIPTION
  • TR_LANGUAGE_CREDITS
  • TR_OFFICIAL_LANGUAGES
  • TR_COMMUNITY_LANGUAGES

Related Issue

Resolve #7624

Screenshots:

Screenshot 2023-08-11 at 12 45 41 PM

@komret
Copy link
Contributor

komret commented Aug 14, 2023

@sime @Hermez-cz I find the copy somewhat confusing:

  • "The Trezor community translated Czech..." - and yet, we call it "official", not "community". Also, we only mention Czech while there are more translations by the community. Also, most users don't speak Czech, but we show this to all of them.
  • "Ensure language consistency by referring to our official languages for verification." - I find this sentence hard to understand.
  • "See credits": The linked page does not show credits.

Copy link
Contributor

@komret komret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, squash the commits into one.

I have some doubts regarding the design/copy, but code is fine.

@AdamSchinzel AdamSchinzel merged commit ddf5087 into develop Aug 14, 2023
5 checks passed
@AdamSchinzel AdamSchinzel deleted the feat/label-translations branch August 14, 2023 14:27
@Hermez-cz
Copy link

@komret thank you for your feedbacks.

  • The "Community language" text in the design is only an example (example in English about Czech for everyone here to understand the meaning). It should be shown only when a community language is selected and it should be shown in that very language and speaking about he selected language (= if user selects an official language, no such text should be shown).
  • "Ensure language consistency by referring to our official languages for verification." I'll check if we might simplify while keeping it short.
  • It's hard to lead directly to "Credits" on Crowdin, so we have included a link just to the project, where the users can find it (especially when logged in). We might direct the link to https://crowdin.com/project/trezor-suite/activity-stream but it's a bit fuzzy.

@Hermez-cz
Copy link

Let's move the Czech language to community languages please. That will leave us only with English in the official ones, but that will change soon. Czech language is translated very well, but by the community incl. our internal colleagues. We will move it to the official once it will be professionally proofread.

@Hermez-cz
Copy link

Final & agreed solution:

  • The description text will only be shown when one of the community languages will be selected, that means it will be shown in that very language
  • Final copy in English (only as source for translations, it will never be shown as english is an official language): A big thanks to the Trezor community for helping out with this translation. You can always refer to one of the official languages if needed.
  • The input and the button will have the same width to stay aligned (✅ solved in fix(suite): device label input #9233 )

@hrudolf
Copy link

hrudolf commented Aug 24, 2023

I'm happy that this issue got a solution and community languages got closer to deployment. I've posted a question to TR_LANGUAGE_DESCRIPTION on Crowdin if the Nationality in the message should be translated to the selected country's nationality (eg. it's Cesky for Czech, magyar for Hungarian). I think that's the intention, right? Could someone from Trezor please add an answer there so that other translators may translate it accordingly? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Label community translations
4 participants