Catch an exception and update the migration status to error.

triadev · Sep 16, 2018 · e6cbe74 · e6cbe74
1 parent 942eceb
commit e6cbe74
Show file tree

Hide file tree

Showing 2 changed files with 52 additions and 23 deletions.
diff --git a/src/ElasticsearchMigration.php b/src/ElasticsearchMigration.php
@@ -60,36 +60,45 @@ private function buildElasticsearchClient() : Client
      */
     public function migrate(string $version)
     {
-        if ($this->migrationRepository->find($version)) {
+        $migration = $this->migrationRepository->find($version);
+        if ($migration && $migration->getAttribute('status') == 'done') {
             throw new MigrationAlreadyDone();
         }
 
-        $migrations = $this->buildMigrations($version);
-
-        foreach ($migrations as $migration) {
-            if ($migration->getType()) {
-                switch ($migration->getType()) {
-                    case 'create':
-                        (new CreateIndex())->migrate($this->esClient, $migration);
-                        break;
-                    case 'update':
-                        (new UpdateIndex())->migrate($this->esClient, $migration);
-                        break;
-                    case 'delete':
-                        (new DeleteIndex())->migrate($this->esClient, $migration);
-                        break;
-                    default:
-                        break;
+        try {
+            $migrations = $this->buildMigrations($version);
+
+            if (!empty($migrations)) {
+                foreach ($migrations as $migration) {
+                    if ($migration->getType()) {
+                        switch ($migration->getType()) {
+                            case 'create':
+                                (new CreateIndex())->migrate($this->esClient, $migration);
+                                break;
+                            case 'update':
+                                (new UpdateIndex())->migrate($this->esClient, $migration);
+                                break;
+                            case 'delete':
+                                (new DeleteIndex())->migrate($this->esClient, $migration);
+                                break;
+                            default:
+                                break;
+                        }
+                    }
+
+                    (new \Triadev\EsMigration\Business\Migration\Alias())->migrate($this->esClient, $migration);
+                    (new \Triadev\EsMigration\Business\Migration\Reindex())->migrate($this->esClient, $migration);
+                    (new \Triadev\EsMigration\Business\Migration\DeleteByQuery())->migrate($this->esClient, $migration);
+                    (new \Triadev\EsMigration\Business\Migration\UpdateByQuery())->migrate($this->esClient, $migration);
                 }
+
+                $this->migrationRepository->createOrUpdate($version, 'done');
             }
+        } catch (\Exception $e) {
+            $this->migrationRepository->createOrUpdate($version, 'error');
 
-            (new \Triadev\EsMigration\Business\Migration\Alias())->migrate($this->esClient, $migration);
-            (new \Triadev\EsMigration\Business\Migration\Reindex())->migrate($this->esClient, $migration);
-            (new \Triadev\EsMigration\Business\Migration\DeleteByQuery())->migrate($this->esClient, $migration);
-            (new \Triadev\EsMigration\Business\Migration\UpdateByQuery())->migrate($this->esClient, $migration);
+            throw $e;
         }
-
-        $this->migrationRepository->createOrUpdate($version, 'done');
     }
 
     /**

diff --git a/tests/integration/ElasticsearchMigrationTest.php b/tests/integration/ElasticsearchMigrationTest.php
@@ -294,4 +294,24 @@ public function it_throws_an_exception_if_migration_already_done()
 
         $this->service->migrate('1.0.0');
     }
+
+    /**
+     * @test
+     */
+    public function it_updates_migration_status_from_error_to_done()
+    {
+        $this->migrationRepository->createOrUpdate('1.0.0', 'error');
+
+        $this->assertEquals(
+            'error',
+            $this->migrationRepository->find('1.0.0')->getAttribute('status')
+        );
+
+        $this->service->migrate('1.0.0');
+
+        $this->assertEquals(
+            'done',
+            $this->migrationRepository->find('1.0.0')->getAttribute('status')
+        );
+    }
 }