-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include distribution regions #44
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some columns were not loaded correctly due to NAs in very first part of file, so R thought these columns were logicals instead of characters. For brevity, use .default parameter.
some verificationKey are linekd to multiple values in taxonKey. This field should be read as character because it can contains a pipe.
Via this approach we have some changes in distributions of unified, with more Belgian distributions.
Authomatic change while mapping descriptions. However, no change in results.
Applied to 5_***.Rmd and 6_***.Rmd
4 tasks
for Fallopia, Mahonia, Lysichiton, Mimulus
Most changes are related to update of GBIF backbone ref from 2017 tot 2019
…o include-distribution-regions
+ resetting some added dates that were manually added by @timadriaens. Tim, when updating the verification, do not update dateAdded 👌
Adding some new lines and outdating others (set to TRUE)
See data/processed/taxon.csv
peterdesmet
approved these changes
Oct 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @damianooldoni. Sorry it took so long. Also included:
- Backbone changes
- update Ludwigia #46
- Update verification #47
I removed the external location mapping file for Spuitkom etc. and just used recode()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #43 and includes regional distributions in unified checklist.
Most of the changes are in
5_unify_information.Rmd
. Minor changes in6_dwc_mapping.Rmd
.Here below the new workflow, in bold the steps added, in italic the steps modified:
temporal
(eventDate) information.locality
andlocationId
to regional or national level. (see table in Include distribution for regions #43)locality
andlocationId
togroup_by()
)locality
andlocationId
togroup_by()
)In DWC mapping, only minor changes applied:
distribution %<>% mutate(dwc_locationID = locationId)
instead ofdistribution %<>% mutate(dwc_locationID = "ISO_3166-2:BE)
distribution %<>% mutate(dwc_locality = locality)
instead ofdistribution %<>% mutate(dwc_locality = "Belgium")
To avoid massive amount of warnings while transforming
Inf
/-Inf
to integer, I split themutate
call to calculatestartYear
andendYear
within checklists in two steps. The change has no influence on results, but it improve code and speed as no warnings have to be returned.I applied to the two Rmd files the commando
styler::style_file()
as last commit. I advice to use it on all other mapping steps as well.