Put sudo parent process in background if stdout is a pipe #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdrz
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disabled polling the stdin file descriptor (which causes input to be grabbed by sudo) if stdout is not connected to a terminal. This is similar to what ogsudo does (in fact this fix was suggested by Todd).
This fixes #1260 for me.
To be more confirming, we should probably only set the process to background mode if stdout is connected to a pipe. But currently the mode "trying to read from the TTY" when stdout is not connected to the TTY results in a recognizable error condition anyway (I don't believe this is by design, but before we change that we may need to consider whether the current behaviour has security benefits).